Feature/nukable permission check for resources #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james03160927
force-pushed
the
feature/nukable-permission-check-for-resources
branch
from
d29ba70 to
d09622f
Compare
denis256
reviewed
May 8, 2024
aws/resources/nat_gateway.go
Outdated
| @@ -162,6 +172,12 @@ func (ngw *NatGateways) areAllNatGatewaysDeleted(identifiers []*string) (bool, e | |||
| func (ngw *NatGateways) deleteAsync(wg *sync.WaitGroup, errChan chan error, ngwID *string) { | |||
| defer wg.Done() | |||
|
|
|||
| if nukable, err := ngw.IsNukable(awsgo.StringValue(ngwID)); !nukable { | |||
There was a problem hiding this comment.
Looks like value of err is not checked, same thing in other places
There was a problem hiding this comment.
Modified the code. It's not an actual error. It should be clearer with the renaming of the variable.
|
There seems to be issue with running tests for circleCI because there are too many at this point. Need to fix that in separate PR. |
denis256
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #000.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide